Serializing a stack to XML in C#

Serializing a class to XML in C# is straightforward; most collections can be easily serialized also.

Something like the following will work in most scenarios –

public string GetSerializedString<T>(T objectToSerialize)
{
    var serializer = new XmlSerializer(typeof(T));
    TextWriter textWriter = new StringWriter();

    var xmlWriter = XmlWriter.Create(textWriter);
    serializer.Serialize(xmlWriter, objectToSerialize);

    string result = textWriter.ToString();
    return result;
}

This also works nicely with lists, arrays and the like. But if you want to serialize a stack to XML you get an InvalidOperationException
You must implement a default accessor on System.Collections.Generic.Stack`1[[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]] because it inherits from ICollection.

There might be some third party libraries out there that will work but I’m going to stick with Microsoft technologies.

So I need to add an accessor to a stack, but a quick look at the System.Collections.Generic.Stack class using dotPeek shows that the underlying collection is a private array.

namespace System.Collections.Generic
{
    public class Stack<T> : IEnumerable<T>, ICollection, IEnumerable
    {
        private T[] _array;
    ...snip...

I could inherit from the Stack class, access the private array through reflection and add the required interface and methods to my class, or I could write my own stack class, but I don’t like these approaches.
An alternative is to start with a collection that can be serialized to XML successfully and add the required stack functionality, peek, pop and push, to it. This a relatively straightforward approach, is easy to understand and provides a familiar interface. I chose to use the List as my base class.

using System.Collections.Generic;
using System.Linq;

namespace SerializingStack
{
    public class StackList<T> : List<T>
    {
        #region Public Methods

        public void Push(T historyItem)
        {
            Add(historyItem);
        }

        public T Pop()
        {
            if (this.Any())
            {
                T historyItem = base[Count - 1];
                Remove(historyItem);
                return historyItem;
            }

            return default(T);
        }

        public T Peek()
        {
            if (this.Any())
            {
                return base[Count - 1];
            }
            return default(T);
        }

        #endregion
    }
}

A problem with this approach is that order that items come out of the enumerator is the opposite from a traditional stack, but as long as the stack is accessed using peek, pop and push it will work the same. Compromises have to be accepted with mixing the features of two different types.

After deserialization

If you have never deserialized a stack then you can just use the StackList with no problems.

If you are used to working with stack, you’ll know that a stack create from another Stack will have its contents reversed. To overcome this you can call the Reverse method on the new stack. This is due to the way the stack constructor is written.

public Stack(IEnumerable<T> collection)
{
    ...snip...
    ICollection<T> collection1 = collection as ICollection<T>;
    if (collection1 != null)
    {
        ...snip...
        collection1.CopyTo(this._array, 0);
        ...snip...
    }
}

If you want to overcome this issue you will need to implement your own enumerator functionality, this is not very difficult, but I didn’t need to do it for my purposes so I’m not including it here.

Conclusions

Be careful as you create your own types that inherit from Microsoft types, especially when you alter how parts of them work!
Every step you take away from the standard approach you are getting in to trouble, it might not be apparent immediately, but it will catch up with you.
This StackList is a cross between and a stack and list that behaves in some particular/peculiar ways that suit me for a for a limited purpose, I don’t plan to use this code widely.

Deserializing to an enum

I have an application where I deserialize an xml stream from a third party. One of the fields is a task code which can be one of only three values, insert, update and delete. This is an obvious candidate for an enum.

public enum TaskCode
{
    Delete,
    Insert,
    Update
}

This is looks good but relies on the xml stream using the same capitalization as shown above, however my incoming xml stream used all caps. I could have changed my enums to all caps, but I’d end up with some ugly lines of code.

Fortunately the XmlEnum attribute solves this problem.

public enum TaskCode
{
    [XmlEnum("DELETE")] Delete,
    [XmlEnum("INSERT")] Insert,
    [XmlEnum("UPDATE")] Update
}

See http://msdn.microsoft.com/en-us/library/system.xml.serialization.xmlenumattribute.aspx for more.